Skip to content

Fix/ui5 proxy middleware/path replace #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 6, 2025
Merged

Fix/ui5 proxy middleware/path replace #3694

merged 10 commits into from
Oct 6, 2025

Conversation

@heimwege
Copy link
Contributor

@heimwege heimwege commented Oct 2, 2025 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 13f2066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 52 packages
Name Type
@sap-ux/ui5-proxy-middleware Patch
@sap-ux/ui5-config Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/create Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/launch-config Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/project-access Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/generator-adp Patch
@sap-ux/preview-middleware Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/annotation-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/project-input-validator Patch
@sap-ux/project-integrity Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-test-writer Patch
@sap-ux-private/adaptation-editor-tests Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/ui5-library-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege requested a review from ytpo-lyne October 2, 2025 12:03
@heimwege heimwege added the ui5-proxy-middleware @sap-ux/ui5-proxy-middleware label Oct 2, 2025
@heimwege heimwege marked this pull request as ready for review October 2, 2025 13:09
@heimwege heimwege requested review from a team as code owners October 2, 2025 13:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ytpo-lyne
ytpo-lyne approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@ytpo-lyne ytpo-lyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code changes for pathReplace look good
  • changeset present
  • full coverage
  • tested standalone and linked with ux-ui5-tooling

Thanks for providing the fix - Approving.

devinea
devinea approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are clear and covered by tests.
Changeset 👍

@ytpo-lyne ytpo-lyne merged commit d866995 into main Oct 6, 2025
16 checks passed
@ytpo-lyne ytpo-lyne deleted the fix/ui5-proxy-middleware/pathReplace branch October 6, 2025 10:46
devinea added a commit that referenced this pull request Oct 6, 2025
@devinea
Merge remote-tracking branch 'origin/main' into improve_doc_search_re…
596fc0e 
…sults_fpm_script

* origin/main:
  chore: apply latest changesets
  mcp - Refactor doc search to return human readable results. Simplify search and doc indexing (#3680)
  chore: apply latest changesets
  Fix/ui5 proxy middleware/path replace (#3694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devinea devinea devinea approved these changes

@ytpo-lyne ytpo-lyne ytpo-lyne approved these changes

Assignees

No one assigned

Labels

ui5-proxy-middleware @sap-ux/ui5-proxy-middleware

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heimwege @devinea @ytpo-lyne